Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gas calc #3356

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Improve gas calc #3356

merged 2 commits into from
Feb 10, 2024

Conversation

JamesSmartCell
Copy link
Member

  • Use Infura gas oracle where available.
  • Ensure up to date gas information has been received before sending transactions.

@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

@codecov Codecov
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 146 lines in your changes are missing coverage. Please review.

Comparison is base (80e6ae7) 7.07% compared to head (550e6b2) 7.05%.

Files Patch % Lines
...java/com/alphawallet/app/service/InfuraGasAPI.java 0.00% 50 Missing ⚠️
...ava/com/alphawallet/app/entity/GasPriceSpread.java 0.00% 31 Missing ⚠️
...in/java/com/alphawallet/app/widget/GasWidget2.java 0.00% 19 Missing ⚠️
...ain/java/com/alphawallet/app/widget/GasWidget.java 0.00% 18 Missing ⚠️
.../com/alphawallet/app/widget/ActionSheetDialog.java 0.00% 9 Missing ⚠️
...lphawallet/app/repository/EthereumNetworkBase.java 33.33% 6 Missing ⚠️
...n/java/com/alphawallet/app/service/GasService.java 0.00% 6 Missing ⚠️
...m/alphawallet/app/entity/ActionSheetInterface.java 0.00% 2 Missing ⚠️
.../alphawallet/app/repository/HttpServiceHelper.java 0.00% 2 Missing ⚠️
...com/alphawallet/app/service/BlockNativeGasAPI.java 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             master   #3356      +/-   ##
===========================================
- Coverage      7.07%   7.05%   -0.03%     
+ Complexity      881     879       -2     
===========================================
  Files           677     679       +2     
  Lines         46748   46874     +126     
  Branches       4747    4760      +13     
===========================================
- Hits           3308    3307       -1     
- Misses        43148   43275     +127     
  Partials        292     292

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesSmartCell JamesSmartCell merged commit 9677256 into master Feb 10, 2024
8 of 9 checks passed
@JamesSmartCell JamesSmartCell deleted the improve-gas-calc branch February 10, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JamesSmartCell